Skip to main content

Rewrite a Harsh Comment

Transform a harsh review comment into label, behavior, impact, and next move.

code-review-skills5 min read

A reviewer wants to say “This abstraction is bad” on a notification PR. Label intent → name code behavior → explain impact → offer next move. The common shortcut is to publish the conclusion without the evidence. The author hears judgment, not a fixable technical concern. Before This abstraction is bad. Please clean it up. After Required: NotificationDispatcher now owns template selection, vendor payloads, and retry state. That couples three reasons to change, so adding push notifications will touch this class again. Can we move vendor formatting behind channel adapters before merge? 1. Label Choose “Required” because the abstraction creates…

Read the full lesson

Sign up free: one personalized lesson every day, matched to your role and goals.

← Back to library

Contact us